This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] [powerpc] fegetmode: utilize faster method to get rounding mode


On Thu, 6 Jun 2019, Paul A. Clarke wrote:

> From: "Paul A. Clarke" <pc@us.ibm.com>
> 
> Add support to use 'mffsl' instruction if compiled for POWER9 (or later).

The patch subject says "rounding mode".  fegetmode should save all control 
modes, not just the rounding mode.  (The C2x wording is "all the dynamic 
floating-point control modes".)

My understanding is that the change is in fact correct - mffsl does save 
all control modes (e.g. exception enable and non-IEEE bit), not just the 
rounding mode (and includes both binary and decimal rounding modes) - and 
so this is just an issue with the patch description, not the code changes.

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]