This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] libio: use stdout in puts and putchar, etc [BZ #24051].


On Thu, Jan 3, 2019 at 5:17 AM Siddhesh Poyarekar <siddhesh@gotplt.org> wrote:
>
> On 03/01/19 6:38 PM, Florian Weimer wrote:

> > You should use array_length (buf) here (and include <array_length.h>).
> > fgetws does not expect a ybte byte count.

Thanks for catching that.

> Fine from the freeze perspective, but this needs a more descriptive
> commit description.

Revised patch attached.

With respect to timing, I would prefer to postpone pushing this to
master until after 2.29 is released, so that both stdout and stdin
(which I'll fix next) are fixed together in 2.30.

Alternatively, I can extend this patch to also cover stdin. Maybe
that's actually better?

Thanks!
-- 
Paul Pluzhnikov

Attachment: glibc-bz24051-20190103.txt
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]