This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: glibc 2.29 - Winter is coming...
On 1/2/19 7:20 PM, Rafal Luzynski wrote:
> 2.01.2019 19:24 Siddhesh Poyarekar <siddhesh@gotplt.org> wrote:
>> Other than that, this seems like something we can make an exception for,
>> assuming that it does not affect translations.
>
> It does not affect translations of glibc but does affect translations of
> applications to a minor extent: the zero-padded output is one character
> wider than the non-zero-padded one. But:
>
> * this is exactly what they want,
> * the output for the current year (and 21 previous years) is already the
> same wide as a zero-padded single digit year.
>
>> I personally would have
>> done 2 different patches, but I know others in the community who would
>> have stuck this into a single patch so I don't have too strong an
>> opinion about that aspect of this patch.
>
> The other issue is that the additional flags like "%-EY" or "%_EY" are
> ignored. I was going to say that this is not related with the era
> change but actually it is: as long as the year number had 2 digits
> those flags were correctly ignored. Now the users will have a good
> reason to expect them to work correctly.
I think that this should be split into two patches immediately.
The "%-EY"/"%_EY" could go in as a bug fix right away.
The default for padding needs more review but could be given an exception
while we review the patch. I think both the patches should go in to 2.29,
but need a little more work as Paul Eggert suggests.
They are important changes to get into 2.29 because of the Japanese Era
name change. Once the patches are in master they will allow the later
patches in April to be applied once the Era name is announced.
These changes are important to downstream enterprise distributions, but
in that case we only care that they land in master at some point. We want
a canonical solution that everyone is using.
The new Era name will likely have to be backported to all the active
open stable branches so they can display the new Era name.
--
Cheers,
Carlos.