Re: [PATCH v5 1/1] Add statx conditionals for wordsize-32 *xstat.c

[Mao Han <han_mao at c-sky dot com>]

On Sat, Dec 15, 2018 at 08:12:03PM +0800, Mao Han wrote:
> On Fri, Dec 14, 2018 at 08:58:29PM +0000, Joseph Myers wrote:
> > On Mon, 10 Dec 2018, Mao Han wrote:
> > 
> > > diff --git a/sysdeps/unix/sysv/linux/generic/wordsize-32/xstat64.c b/sysdeps/unix/sysv/linux/generic/wordsize-32/xstat64.c
> > > +#ifdef __NR_fstatat64
> > >      return INLINE_SYSCALL (fstatat64, 4, AT_FDCWD, name, buf, 0);
> > > -
> > As this statement is moving inside braces, it also needs to be reindented 
> > two more columns to the right.
> 
> OK, I'll fix the style.
> 
> > > +extern void __cp_stat_statx (struct stat *to, struct statx *from)
> > > +  attribute_hidden;
> > 
> > There's no such function any more, so this declaration should be removed.
> 
> OK, I'll remove it.

Committed. with fixes above.
Did a make check for mips, nios2 and x86.

> > This patch is OK with those changes.  Please complete the form 
> > https://sourceware.org/cgi-bin/pdw/ps_form.cgi for write access, listing 
> > me as sponsor.  Please also create an account on the glibc wiki if you 
> > don't already have one, and post the username so that you can be given 
> > write access to that.
> 
> I'v completed the form to request a sourceware account. The glibc wiki
> account is also created and the username is: HanMao

Some one can help add me to the wiki editor group? My account was purged
yesterday. I've just recreated it.

Thanks,
Mao Han