This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v5 1/1] Add statx conditionals for wordsize-32 *xstat.c
On Sat, 15 Dec 2018, Mao Han wrote:
> I'v completed the form to request a sourceware account. The glibc wiki
> account is also created and the username is: HanMao
Thanks, I've added you to EditorGroup.
There is one thing to watch on this patch for future reference (no action
required at present). statx always uses 64-bit timestamps, so for 32-bit
systems __cp_stat64_statx will quietly set the timestamps to just the low
32 bits of the timestamps provided by the kernel. Now, this currently
matches what the Linux kernel does for the stat syscalls on 32-bit systems
that have them, when using a filesystem that supports timestamps outside
the 32-bit time_t range. But if the Linux kernel changes its handling of
such out-of-range timestamps in future (whether producing EOVERFLOW
errors, saturating or anything else - there has been past discussion, see
<https://bugzilla.redhat.com/show_bug.cgi?id=1419736> and linux-fsdevel
link therein, but I'm not sure there was any conclusion), the stat
emulation using statx should change to match.
--
Joseph S. Myers
joseph@codesourcery.com