This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] signal: Use correct type for si_band in siginfo_t [BZ #23562]

On Mon, 22 Oct 2018, Florian Weimer wrote:

> > For 64-bit SPARC this would be a case where the kernel having the
> > wrong type means you need an appropriately conditioned and commented
> > XFAIL in signal.h-data and sys/wait.h-data (and appropriately
> > conditioned and commented conformtest-xfail-conds definition in a
> > relevant sysdeps Makefile to define the condition that's used in the
> > conform/ data changes).
> Why wasn't this a problem before
> sysdeps/unix/sysv/linux/bits/types/siginfo_t.h was split out?  SPARC
> clearly had int as the type of si_band back then.

XFAILs at the Makefile level for the signal.h and sys/wait.h tests for 
most standards weren't removed until August 2017 (commit 
4fa9b3bfe6759c82beb4b043a54a3598ca467289, once the ucontext.h namespace 
fixes were completed), after the accidental SPARC si_band change, and so 
served to hide that architecture-specific problem.

Joseph S. Myers

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]