This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2] Enable VDSO on statically linked programs.
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Rafael Avila de Espindola <rafael at espindo dot la>
- Cc: "libc-alpha at sourceware dot org" <libc-alpha at sourceware dot org>
- Date: Mon, 24 Sep 2018 06:25:00 -0700
- Subject: Re: [PATCH v2] Enable VDSO on statically linked programs.
- References: <Rt9LNuZNJXNeI-mSgZ_YAja7MzVVLO7IYVyN2uyhHcnpBpJH9yzQATx-2GaiHZoMA6mScM6GvrheNFkdCQK4ZGmDbbXhVJ-RI1dp0AGlezA=@espindo.la> <CAMe9rOppStbmn2ti4HyH0HhExbCvrujviE7Xn_o_1ghwyYu5DA@mail.gmail.com> <XNcH30lFg98oSB9zboHnE6yyWrf17zM7Tvwn8I6dmLaVx6FNrcxBMdW7wGJRygN2T9StKHxBJG6D2_zvj9D-USL_avfn-B12BaxdVn3JqV8=@espindo.la>
On Sun, Sep 23, 2018 at 6:24 PM, Rafael Avila de Espindola
<rafael@espindo.la> wrote:
> "H.J. Lu" <hjl.tools@gmail.com> writes:
>
>> On Fri, Sep 21, 2018 at 4:40 PM, Rafael Avila de Espindola
>> <rafael@espindo.la> wrote:
>>> The new version has fixed the indentation of preprocessor directives and changed a few tests to also be linked statically. The tests don't show that the VDSO is being used, but show that the functions now using the VDSO still work.
>>>
>>
>> 2 comments:
>>
>> 1. Why isn't i386 enabled?
>
> It is probably better to do other architectures as a follow up, no? I do
> volunteer to do at least i386.
Your patch changed sysdeps/unix/sysv/linux/x86/libc-vdso.h
which is used for both i386 and x86-64. You just need to make
similar changes in sysdeps/unix/sysv/linux/i386/init-first.c.
BTW, You can test i686 on x86-64.
>
>> 2. ChangeLog entries are missing.
>
> Sorry, it is
>
> 2018-09-23 Rafael Ávila de Espíndola <rafael@espindo.la>
>
> * nptl/Makefile: Add tst-cond11-static to tests-static and tests.
> * nptl/tst-cond11-static.c: New File.
> * sysdeps/unix/sysv/linux/sysdep-vdso.h: remove #ifdef SHARED.
> * sysdeps/unix/sysv/linux/x86/libc-vdso.h: remove #ifdef SHARED.
> * sysdeps/unix/sysv/linux/x86_64/init-first.c: remove #ifdef SHARED.
> * sysdeps/unix/sysv/linux/Makefile: Add tst-affinity-static to
> tests-static and tests
> * sysdeps/unix/sysv/linux/tst-affinity-static.c: New file.
>
> Cheers,
> Rafael
>
--
H.J.