This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2] Enable VDSO on statically linked programs.

On 24/09/18 02:24, Rafael Avila de Espindola wrote:
"H.J. Lu" <> writes:

On Fri, Sep 21, 2018 at 4:40 PM, Rafael Avila de Espindola
<> wrote:
The new version has fixed the indentation of preprocessor directives and changed a few tests to also be linked statically. The tests don't show that the VDSO is being used, but show that the functions now using the VDSO still work.


1.  Why isn't i386 enabled?

It is probably better to do other architectures as a follow up, no? I do
volunteer to do at least i386.

2.  ChangeLog entries are missing.

Sorry, it is

2018-09-23  Rafael Ávila de Espíndola  <>

         * nptl/Makefile: Add tst-cond11-static to tests-static and tests.
         * nptl/tst-cond11-static.c: New File.
         * sysdeps/unix/sysv/linux/sysdep-vdso.h: remove #ifdef SHARED.
         * sysdeps/unix/sysv/linux/x86/libc-vdso.h: remove #ifdef SHARED.
         * sysdeps/unix/sysv/linux/x86_64/init-first.c: remove #ifdef SHARED.
         * sysdeps/unix/sysv/linux/Makefile: Add tst-affinity-static to
         tests-static and tests
         * sysdeps/unix/sysv/linux/tst-affinity-static.c: New file.

this should include the bug number 19767

the title as well as the description should make it clear that
only x86 behaviour is changed, this is a generic issue in glibc
and ideally all targets should have the same behaviour eventually.

it is also useful to mention if you tested the patch on non-x86
targets since the header changes seem to affect them.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]