This is the mail archive of the
mailing list for the glibc project.
Re: [PATCH] Use generic sinf/cosf in lgammaf_r
On Wed, 15 Aug 2018, Wilco Dijkstra wrote:
> Joseph Myers wrote:
> > I'd expect the sysdeps/powerpc/fpu versions of k_cosf.c and k_sinf.c to be
> > removed as well, since this patch makes them useless.
> It seems sysdeps/powerpc/fpu/s_sinf.c still needs that __kernel_sinf.
> It would be nice if powerpc moved to the generic sinf/cosf instead (this may
> need the PREFER_FLOAT_COMPARISON feature added again).
Thanks. In that case the patch is OK as-is, but I strongly encourage
powerpc maintainers to look at eliminating these powerpc/fpu function
implementations after doing anything necessary to make the generic ones at
least as fast on powerpc.
Joseph S. Myers