This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Use generic sinf/cosf in lgammaf_r
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Wilco Dijkstra <Wilco dot Dijkstra at arm dot com>
- Cc: "libc-alpha at sourceware dot org" <libc-alpha at sourceware dot org>, nd <nd at arm dot com>
- Date: Tue, 14 Aug 2018 19:34:07 +0000
- Subject: Re: [PATCH] Use generic sinf/cosf in lgammaf_r
- References: <DB5PR08MB10302432684E91C1FF51786C83380@DB5PR08MB1030.eurprd08.prod.outlook.com>
On Tue, 14 Aug 2018, Wilco Dijkstra wrote:
> The internal functions __kernel_sinf and __kernel_cosf are used only by
> lgammaf_r. Removing the internal functions and using the generic sinf
> and cosf is better overall. Benchmarking on Cortex-A72 shows the generic
> sinf and cosf are 1.4x and 2.3x faster in the range |x| < PI/4, and 0.66x
> and 1.1x for |x| < PI/2, so it should make lgammaf_r faster on average.
I'd expect the sysdeps/powerpc/fpu versions of k_cosf.c and k_sinf.c to be
removed as well, since this patch makes them useless.
--
Joseph S. Myers
joseph@codesourcery.com