This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Use generic sinf/cosf in lgammaf_r

From: Wilco Dijkstra <Wilco dot Dijkstra at arm dot com>
To: Joseph Myers <joseph at codesourcery dot com>
Cc: "libc-alpha at sourceware dot org" <libc-alpha at sourceware dot org>, nd <nd at arm dot com>
Date: Wed, 15 Aug 2018 13:06:27 +0000
Subject: Re: [PATCH] Use generic sinf/cosf in lgammaf_r
References: <DB5PR08MB10302432684E91C1FF51786C83380@DB5PR08MB1030.eurprd08.prod.outlook.com>,<alpine.DEB.2.20.1808141933010.21830@digraph.polyomino.org.uk>

Joseph Myers wrote:

> I'd expect the sysdeps/powerpc/fpu versions of k_cosf.c and k_sinf.c to be 
> removed as well, since this patch makes them useless.

It seems sysdeps/powerpc/fpu/s_sinf.c still needs that __kernel_sinf.
It would be nice if powerpc moved to the generic sinf/cosf instead (this may
need the PREFER_FLOAT_COMPARISON feature added again).

It also seems there is only one use left of __ieee754_rem_pio2f.
tanf could use reduce_large instead, allowing removal of 400 lines of
horribly complicated code...

Wilco

Follow-Ups:
- Re: [PATCH] Use generic sinf/cosf in lgammaf_r
  - From: Joseph Myers

References:
- [PATCH] Use generic sinf/cosf in lgammaf_r
  - From: Wilco Dijkstra
- Re: [PATCH] Use generic sinf/cosf in lgammaf_r
  - From: Joseph Myers

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]