This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 00/12] S390: Implement __fentry__
- From: Stefan Liebler <stli at linux dot ibm dot com>
- To: Ilya Leoshkevich <iii at linux dot ibm dot com>, libc-alpha at sourceware dot org
- Cc: Florian Weimer <fweimer at redhat dot com>
- Date: Tue, 7 Aug 2018 10:27:12 +0200
- Subject: Re: [PATCH 00/12] S390: Implement __fentry__
- References: <20180802075735.3457-1-iii@linux.ibm.com>
On 08/02/2018 09:57 AM, Ilya Leoshkevich wrote:
This patch series adds the runtime support in glibc for the -mfentry
gcc feature introduced in [1] and [2].
Patches 1-9 deal with avoiding clobbering %r0 when calling lazily bound
functions, so that the new __fentry__ symbol could be called with return
address in that register.
Patch 10 removes the assumption that only Intel implements __fentry__.
Patch 11 adds __fentry__ implementation.
Patch 12 is a cleanup of problems in 31-bit mcount, which are similar to
those found while implementing 64-bit __fentry__.
[1] https://gcc.gnu.org/ml/gcc-patches/2018-07/msg00784.html
[2] https://gcc.gnu.org/ml/gcc-patches/2018-07/msg00912.html
Hi,
I've reviewed the s390-specific patches. They are all okay.
I think the move of the Intel-specific __fentry__ defintion into the
Versions-files of the corresponding sysdeps directories is okay, too.
Do anybody complain about that?
If not, I plan to commit this patch-series at the end of this week.
Thank you for implementing the __fentry__ support for s390x.
Bye
Stefan