This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [COMMITTED] [PATCH 00/12] S390: Implement __fentry__

On 08/07/2018 10:27 AM, Stefan Liebler wrote:
On 08/02/2018 09:57 AM, Ilya Leoshkevich wrote:
This patch series adds the runtime support in glibc for the -mfentry
gcc feature introduced in [1] and [2].

Patches 1-9 deal with avoiding clobbering %r0 when calling lazily bound
functions, so that the new __fentry__ symbol could be called with return
address in that register.

Patch 10 removes the assumption that only Intel implements __fentry__.

Patch 11 adds __fentry__ implementation.

Patch 12 is a cleanup of problems in 31-bit mcount, which are similar to
those found while implementing 64-bit __fentry__.



I've reviewed the s390-specific patches. They are all okay.

I think the move of the Intel-specific __fentry__ defintion into the Versions-files of the corresponding sysdeps directories is okay, too.
Do anybody complain about that?

If not, I plan to commit this patch-series at the end of this week.
Thank you for implementing the __fentry__ support for s390x.




Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]