This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] time: Define _STRUCT_TIMESPEC in <bits/types/struct_timespec.h>


On 06/28/2018 11:52 AM, Dmitry V. Levin wrote:
On Thu, Jun 28, 2018 at 10:27:53AM +0200, Florian Weimer wrote:
On 06/21/2018 01:24 PM, Florian Weimer wrote:
diff --git a/time/bits/types/struct_timespec.h b/time/bits/types/struct_timespec.h
index 644db9fdb6..5b77c52b4f 100644
--- a/time/bits/types/struct_timespec.h
+++ b/time/bits/types/struct_timespec.h
@@ -1,5 +1,6 @@
-#ifndef __timespec_defined
-#define __timespec_defined 1
+/* NB: Include guard matches what <linux/time.h> uses.  */
+#ifndef _STRUCT_TIMESPEC
+#define _STRUCT_TIMESPEC 1

Are there any objections to this change?  It's required to fix a GCC
build failure, so I'm going to commit this soon (probably on Friday).

The change looks fine, thanks.

Thanks. I filed bug 23349 to track this and will reference it in the commit.

Florian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]