This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] time: Define _STRUCT_TIMESPEC in <bits/types/struct_timespec.h>

From: Florian Weimer <fweimer at redhat dot com>
To: Zack Weinberg <zackw at panix dot com>
Cc: GNU C Library <libc-alpha at sourceware dot org>
Date: Thu, 28 Jun 2018 10:27:53 +0200
Subject: Re: [PATCH] time: Define _STRUCT_TIMESPEC in <bits/types/struct_timespec.h>
References: <20180621064654.2D7DA4289B0D0@oldenburg.str.redhat.com> <CAKCAbMhgXiesDY+prfjZ_q8hHWUzj=s1r_qb_tcwyOQ_iO3+PQ@mail.gmail.com> <21e4d5b7-f883-4722-0dcc-5e4228720fac@redhat.com>

On 06/21/2018 01:24 PM, Florian Weimer wrote:

diff --git a/time/bits/types/struct_timespec.h b/time/bits/types/struct_timespec.h
index 644db9fdb6..5b77c52b4f 100644
--- a/time/bits/types/struct_timespec.h
+++ b/time/bits/types/struct_timespec.h
@@ -1,5 +1,6 @@
-#ifndef __timespec_defined
-#define __timespec_defined 1
+/* NB: Include guard matches what <linux/time.h> uses.  */
+#ifndef _STRUCT_TIMESPEC
+#define _STRUCT_TIMESPEC 1

Are there any objections to this change? It's required to fix a GCCbuild failure, so I'm going to commit this soon (probably on Friday).


Thanks,
Florian

Follow-Ups:
- Re: [PATCH] time: Define _STRUCT_TIMESPEC in <bits/types/struct_timespec.h>
  - From: Dmitry V. Levin

References:
- [PATCH] time: Define _STRUCT_TIMESPEC in <bits/types/struct_timespec.h>
  - From: Florian Weimer
- Re: [PATCH] time: Define _STRUCT_TIMESPEC in <bits/types/struct_timespec.h>
  - From: Zack Weinberg
- Re: [PATCH] time: Define _STRUCT_TIMESPEC in <bits/types/struct_timespec.h>
  - From: Florian Weimer

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]