This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] time: Define _STRUCT_TIMESPEC in <bits/types/struct_timespec.h>
- From: Zack Weinberg <zackw at panix dot com>
- To: Florian Weimer <fweimer at redhat dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Thu, 21 Jun 2018 07:00:48 -0400
- Subject: Re: [PATCH] time: Define _STRUCT_TIMESPEC in <bits/types/struct_timespec.h>
- References: <20180621064654.2D7DA4289B0D0@oldenburg.str.redhat.com>
On Thu, Jun 21, 2018 at 2:46 AM, Florian Weimer <fweimer@redhat.com> wrote:
> After commit d76d3703551a362b472c866b5b6089f66f8daa8e ("Fix missing
> timespec definition for sys/stat.h (BZ #21371)"), sanitizer builds start
> to fail due to a conflicting definition of struct timespec in
> <linux/time.h>. Define _STRUCT_TIMESPEC, which is already checked in
> the kernel header, to support including <linux/time.h> after
> <sys/stat.h>.
Should it go the other way around as well? That is, if
_STRUCT_TIMESPEC is already defined, should we suppress our
definition?
Either way I think there should be a comment saying that linux/time.h
checks this macro.
zw