This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] add attribute nonstring
On Tue, 21 Nov 2017, Paul Eggert wrote:
> Joseph Myers wrote:
> > This patch is OK, with the corresponding change also to
> > sysdeps/unix/sysv/linux/s390/bits/utmp.h unless you have reason to believe
> > that version of bits/utmp.h doesn't need changing
>
> Are similar changes also needed to bits/utmp.h and to
> sysdeps/unix/sysv/linux/s390/s390-32/utmp32.h? They also define these arrays.
bits/utmp.h is not used by any current glibc configuration, though it
could reasonably be changed.
sysdeps/unix/sysv/linux/s390/s390-32/utmp32.h is a purely internal header,
not an installed one, only relevant for converting between different utmp
formats.
> Also, what about struct utmpx? It has similarly-named fields, which also
> appear to use strncpy format. This affects
I don't see anything clear in the POSIX specification of utmpx.h about
whether these fields are NUL-terminated. In any case, that structure was
not an observed cause of build failures.
--
Joseph S. Myers
joseph@codesourcery.com