This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] add attribute nonstring
- From: Steve Ellcey <sellcey at cavium dot com>
- To: Martin Sebor <msebor at gmail dot com>, Joseph Myers <joseph at codesourcery dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>, Paul Eggert <eggert at cs dot ucla dot edu>
- Date: Wed, 15 Nov 2017 14:09:04 -0800
- Subject: Re: [PATCH] add attribute nonstring
- Authentication-results: sourceware.org; auth=none
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=Steve dot Ellcey at cavium dot com;
- References: <11c4caec-df98-12e6-c6f5-cfc95eb8b8d6@gmail.com>
- Reply-to: sellcey at cavium dot com
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
On Fri, 2017-11-10 at 16:11 -0700, Martin Sebor wrote:
>
> Okay, thanks. I've read that you run periodic Glibc builds with
> the latest GCC so I wanted to give you a heads up on this change
> and the patch to avoid breaking them. Unless that's not a concern
> (do you use -Werror in those builds?) what is the best way to
> coordinate this update?
>
> I CC Paul for his input in case updating tzcode first is important.
>
> Martin
Martin, were you going to update this patch with Joseph's comments and
resubmit? The tz changes are checked in and the ifreq struct is taken
care of so all that remains are the changes to cdefs.h to define
__NONSTRING and then to use in utmp.h. I don't have any comments on
that change beyond what Joseph made but I did do a build and run on
aarch64 with the latest GCC to verify that those changes work for me.
Steve Ellcey
sellcey@cavium.com