This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] add attribute nonstring

From: Joseph Myers <joseph at codesourcery dot com>
To: Martin Sebor <msebor at gmail dot com>
Cc: <sellcey at cavium dot com>, GNU C Library <libc-alpha at sourceware dot org>, Paul Eggert <eggert at cs dot ucla dot edu>
Date: Wed, 15 Nov 2017 23:14:03 +0000
Subject: Re: [PATCH] add attribute nonstring
Authentication-results: sourceware.org; auth=none
References: <11c4caec-df98-12e6-c6f5-cfc95eb8b8d6@gmail.com> <1510783744.1836.25.camel@cavium.com> <b8fa0da8-49a4-1f6f-9d8d-204e5924aa52@gmail.com>

On Wed, 15 Nov 2017, Martin Sebor wrote:

> Sure.  I've got the attached patch.  According to the Linux utmp
> man page:
>        String fields are terminated by a null byte ('\0')
>        if they are shorter than the size of the field.
> 
> The patch lets Glibc compile fine with the top of GCC 8 trunk.

This patch is OK, with the corresponding change also to 
sysdeps/unix/sysv/linux/s390/bits/utmp.h unless you have reason to believe 
that version of bits/utmp.h doesn't need changing.

-- 
Joseph S. Myers
joseph@codesourcery.com

Follow-Ups:
- Re: [PATCH] add attribute nonstring
  - From: Paul Eggert

References:
- Re: [PATCH] add attribute nonstring
  - From: Martin Sebor
- Re: [PATCH] add attribute nonstring
  - From: Steve Ellcey
- Re: [PATCH] add attribute nonstring
  - From: Martin Sebor

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]