This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] fix #19443 - build failures with -DDEBUG
- From: Paul Eggert <eggert at cs dot ucla dot edu>
- To: Martin Sebor <msebor at gmail dot com>, GNU C Library <libc-alpha at sourceware dot org>
- Date: Tue, 12 Jan 2016 13:35:46 -0800
- Subject: Re: [PATCH] fix #19443 - build failures with -DDEBUG
- Authentication-results: sourceware.org; auth=none
- References: <5695641C dot 8090607 at gmail dot com>
On 01/12/2016 12:37 PM, Martin Sebor wrote:
The attached patch makes it possible to build glibc with the macro
defined. In one instance (time/mktime.c) the macro is being used
in a way that's incompatible with the other uses. In that case I
renamed to avoid this problem.
Sounds good.
- ? &((struct sockaddr_in6 *) nsap)->sin6_addr
- : &((struct sockaddr_in *) nsap)->sin_addr),
+ ? (char *)&((struct sockaddr_in6 *) nsap)->sin6_addr
+ : (char *)&((struct sockaddr_in *) nsap)->sin_addr),
In the cast, please use (void *) instead of (char *), and put a space
after the ")". Otherwise, looks good to me; thanks.