This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 2/2] Remove ancient GCC string inlines

Joseph Myers wrote:
> On Thu, 17 Dec 2015, Wilco Dijkstra wrote:
> > Joseph Myers wrote:
> > > I think the previous discussion concluded that a new ABI macro for these
> > > out-of-line functions should be added to replace _STRING_ARCH_unaligned
> > for that purpose, so the patch needs revising rather than simply pinging.
> >
> > We should add another macro indeed, but that can be done in a different patch
> > as my patch doesn't make the existing situation any worse.
> But I think we need both patches before 2.23, to avoid a change to the ABI
> of these functions for AArch64.

You're right that _STRING_ARCH_unaligned has already been changed on AArch64
(but not in this patch) so I'll have a go at adding a new define for this.

However note these functions were never referenced by any AArch64 compiler as
you need a pre 3.0 GCC to get possible references to them when including string.h. 
I'm not sure these symbols are exported by default either.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]