This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Remove Linuxism from tst-tls-atexit
- From: Siddhesh Poyarekar <siddhesh at redhat dot com>
- To: Roland McGrath <roland at hack dot frob dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Wed, 15 Jul 2015 09:13:19 +0530
- Subject: Re: [PATCH] Remove Linuxism from tst-tls-atexit
- Authentication-results: sourceware.org; auth=none
- References: <1436883383-6903-1-git-send-email-siddhesh at redhat dot com> <20150714194025 dot 4608E2C39FA at topped-with-meat dot com> <20150715001837 dot GV2634 at spoyarek dot pnq dot redhat dot com> <20150715010029 dot 104162C39F1 at topped-with-meat dot com>
On Tue, Jul 14, 2015 at 06:00:28PM -0700, Roland McGrath wrote:
> Hmm. Perhaps there is too much being tested in this one test, then?
> One of the things on my list is to clean up the various test cases that
> rely on signal handling when they are not testing something related to
> signal handling. It makes those tests unusable on non-POSIX
> configurations (i.e. currently only NaCl) that do not support signals.
> So adding another such case is kind of going backwards. In this case,
> going from gratuitous Linuxism to just thorough POSIXism is still an
> incremental improvement (it should fix it for Hurd, e.g.). So that is
> fine for now if it really is unavoidably much harder to write a good
> test without catching a signal. But still not ideal.
I'm afraid it is all one test - make sure that the DSO does not unload
with the first dlclose and then make sure that it does with the
second.
Siddhesh