This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Remove Linuxism from tst-tls-atexit
- From: Siddhesh Poyarekar <siddhesh at redhat dot com>
- To: Roland McGrath <roland at hack dot frob dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Wed, 15 Jul 2015 05:48:37 +0530
- Subject: Re: [PATCH] Remove Linuxism from tst-tls-atexit
- Authentication-results: sourceware.org; auth=none
- References: <1436883383-6903-1-git-send-email-siddhesh at redhat dot com> <20150714194025 dot 4608E2C39FA at topped-with-meat dot com>
On Tue, Jul 14, 2015 at 12:40:25PM -0700, Roland McGrath wrote:
> > The tst-tls-atexit test case searches for its module in /proc/PID/maps
> > to verify that it is unloaded, which is a Linux-specific test. This
> > patch makes the test generic by trying to call foo (the symbol
> > obtained from dlsym) and traps SIGSEGV momentarily to see if the crash
> > occurred.
>
> Is there a reason to catch it instead of just setting EXPECTED_SIGNAL?
EXPECTED_SIGNAL makes SIGSEGV OK for the entire test case and we don't
want that. The dlclose inside the thread function LOAD for example
will cause a segfault in __tls_call_dtors if it incorrectly unloads
the DSO.
Siddhesh