Re: [PATCH] Kill regexp.h

[Mike Frysinger <vapier at gentoo dot org>]

On 12 Jul 2015 15:27, Zack Weinberg wrote:
> Therefore, this patch stubs out the header and demotes the
> implementation to compatibility symbols.

our current workflow says that all user visible changes (like this) require a 
bugzilla bug to be created for reference.  please do that and update the various
pieces with that BZ #.

> +#if SHLIB_COMPAT(libc, GLIBC_2_0, GLIBC_2_22)

should be a space before the (

> -/* Define the variables used for the interface.  */
>  char *loc1;
>  char *loc2;
> -
> -/* Although we do not support the use we define this variable as well.  */
>  char *locs;

should probably leave the comments alone

> +compat_symbol(libc, loc1, loc1, GLIBC_2_0);
> +compat_symbol(libc, loc2, loc2, GLIBC_2_0);
> +compat_symbol(libc, locs, locs, GLIBC_2_0);

should be a space before the (

> +#error "GNU libc no longer implements <regexp.h>."
> +#error "Revise your code to use <regex.h> (no P)."

how about changing the parenthetical aside to:
 ... (no trailing 'p').
-mike

Attachment: signature.asc
Description: Digital signature