This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
[PATCH] Export __vdso_clock_gettime as GLIBC_PRIVATE
- From: Siddhesh Poyarekar <siddhesh at redhat dot com>
- To: libc-alpha at sourceware dot org
- Cc: carlos at redhat dot com
- Date: Thu, 22 Jan 2015 13:35:57 +0530
- Subject: [PATCH] Export __vdso_clock_gettime as GLIBC_PRIVATE
- Authentication-results: sourceware.org; auth=none
Hi,
We added vDSO support for time functions on i386 recently, but the
__vdso_clock_gettime symbol was kept as an internal symbol. This is
fine for glibc as is, but it breaks Fedora builds since rtkaio now
needs access to __vdso_clock_gettime. I could maintain a patch in
Fedora that exports this symbol as GLIBC_PRIVATE, but I reckon that it
might be more consistent to put it upstream since all of the
architectures that have vDSO time support export the symbol in
GLIBC_PRIVATE already.
Tested on i386 to verify that the build completes successfully. OK to
commit?
Siddhesh
* sysdeps/unix/sysv/linux/i386/Versions (GLIBC_PRIVATE): Add
__vdso_clock_gettime.
diff --git a/sysdeps/unix/sysv/linux/i386/Versions b/sysdeps/unix/sysv/linux/i386/Versions
index f3544ac..f18cbf3 100644
--- a/sysdeps/unix/sysv/linux/i386/Versions
+++ b/sysdeps/unix/sysv/linux/i386/Versions
@@ -47,5 +47,6 @@ libc {
}
GLIBC_PRIVATE {
__modify_ldt;
+ __vdso_clock_gettime;
}
}