This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Export __vdso_clock_gettime as GLIBC_PRIVATE
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Siddhesh Poyarekar <siddhesh at redhat dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>, "Carlos O'Donell" <carlos at redhat dot com>
- Date: Thu, 22 Jan 2015 04:44:14 -0800
- Subject: Re: [PATCH] Export __vdso_clock_gettime as GLIBC_PRIVATE
- Authentication-results: sourceware.org; auth=none
- References: <20150122133557 dot 515f55dd at redhat dot com>
On Thu, Jan 22, 2015 at 12:05 AM, Siddhesh Poyarekar
<siddhesh@redhat.com> wrote:
> Hi,
>
> We added vDSO support for time functions on i386 recently, but the
> __vdso_clock_gettime symbol was kept as an internal symbol. This is
> fine for glibc as is, but it breaks Fedora builds since rtkaio now
> needs access to __vdso_clock_gettime. I could maintain a patch in
> Fedora that exports this symbol as GLIBC_PRIVATE, but I reckon that it
> might be more consistent to put it upstream since all of the
> architectures that have vDSO time support export the symbol in
> GLIBC_PRIVATE already.
>
> Tested on i386 to verify that the build completes successfully. OK to
> commit?
>
Can you explain why __clock_gettime isn't sufficient?
--
H.J.