This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] * elf/dl-load.c (open_path): avoid writing to 'env_path_list' when none of the search directories exist.

From: Siddhesh Poyarekar <siddhesh at redhat dot com>
To: Allan McRae <allan at archlinux dot org>
Cc: libc-alpha at sourceware dot org
Date: Thu, 22 Jan 2015 12:09:49 +0530
Subject: Re: [PATCH] * elf/dl-load.c (open_path): avoid writing to 'env_path_list' when none of the search directories exist.
Authentication-results: sourceware.org; auth=none
References: <1413158846-7075-1-git-send-email-allan at archlinux dot org> <20141013060210 dot GA3690 at spoyarek dot pnq dot redhat dot com> <5492463F dot 2090907 at archlinux dot org> <20141231095328 dot GF8679 at spoyarek dot pnq dot redhat dot com>

On Wed, 31 Dec 2014 15:23:29 +0530
Siddhesh Poyarekar <siddhesh@redhat.com> wrote:

> On Thu, Dec 18, 2014 at 01:13:03PM +1000, Allan McRae wrote:
> > I have come to the conclusion that I have no idea how to write a
> > test case for this issue.   Can anyone point me in the right
> > direction?
> 
> The bug report seems to have steps to reproduce the problem.  Is it
> not possible to use them to write a test case?

I gave this a shot and it looks fairly difficult to incorporate the
test into the testsuite.  The test needs a custom rpath as well as to
be invoked with a custom --library-path that points to a non-existent
directory.  Such a change is not suitable for the freeze and I don't
think it is worth blocking for this fix either.  I'm OK with this patch
going in without a test.

Siddhesh

Attachment: pgpm3rUCR8YS6.pgp
Description: OpenPGP digital signature

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]