This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: -Werror now enabled by default

On 10-12-2014 14:24, Joseph Myers wrote:
> On Wed, 10 Dec 2014, Andreas Schwab wrote:
>> In other words, you are forcing everyone to use --disable-werror now.
> That's the opposite of what I said.  By "warning suppression" I mean use 
> of the DIAG_* macros, not --disable-werror.
Something like that:

diff --git a/sysdeps/ieee754/ldbl-128/e_lgammal_r.c b/sysdeps/ieee754/ldbl-128/e_lgammal_r.c
index 1961355..641cfd6 100644
--- a/sysdeps/ieee754/ldbl-128/e_lgammal_r.c
+++ b/sysdeps/ieee754/ldbl-128/e_lgammal_r.c
@@ -70,12 +70,16 @@

 #include <math.h>
 #include <math_private.h>
+#include <libc-internal.h>

+DIAG_IGNORE_NEEDS_COMMENT (4.6, "-Woverflow");
 static const long double PIL = 3.1415926535897932384626433832795028841972E0L;
 static const long double MAXLGM = 1.0485738685148938358098967157129705071571E4928L;
 static const long double one = 1.0L;
 static const long double zero = 0.0L;
 static const long double huge = 1.0e4000L;

 /* log gamma(x) = ( x - 0.5 ) * log(x) - x + LS2PI + 1/x P(1/x^2)
    1/x <= 0.0741 (x >= 13.495...)

I still trying to figure out why the test for MAXLGM is necessary (it seems redundant
to me, since for overflow it will be generate by the log call itself).  Anyway, I
know this is not the perfect solution, but I would like to make powerpc builds
cleanly without resorting in --disable-werror.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]