This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: -Werror policy
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Yury Gribov <y dot gribov at samsung dot com>
- Cc: Roland McGrath <roland at hack dot frob dot com>, <libc-alpha at sourceware dot org>
- Date: Tue, 25 Nov 2014 18:22:08 +0000
- Subject: Re: -Werror policy
- Authentication-results: sourceware.org; auth=none
- References: <alpine dot DEB dot 2 dot 10 dot 1411132331520 dot 5050 at digraph dot polyomino dot org dot uk> <20141114001831 dot 8C7CF2C3B16 at topped-with-meat dot com> <alpine dot DEB dot 2 dot 10 dot 1411140028450 dot 5050 at digraph dot polyomino dot org dot uk> <20141124221810 dot 391AC2C3B20 at topped-with-meat dot com> <alpine dot DEB dot 2 dot 10 dot 1411242313250 dot 11608 at digraph dot polyomino dot org dot uk> <20141124235522 dot D37652C3AC8 at topped-with-meat dot com> <alpine dot DEB dot 2 dot 10 dot 1411250013120 dot 11608 at digraph dot polyomino dot org dot uk> <20141125001531 dot 2A8942C3ADB at topped-with-meat dot com> <alpine dot DEB dot 2 dot 10 dot 1411250028130 dot 11608 at digraph dot polyomino dot org dot uk> <5474BF6D dot 6090707 at samsung dot com> <alpine dot DEB dot 2 dot 10 dot 1411251744250 dot 18401 at digraph dot polyomino dot org dot uk> <5474C4A0 dot 3050600 at samsung dot com>
On Tue, 25 Nov 2014, Yury Gribov wrote:
> I'm not sure: the knowledge that error suppression is explained elsewhere is
> implicit in code. So if e.g. someone works on surrounding code and removes
> the master comment, all other suppressions will become undocumented. This
> would be hard to spot during reviews.
Well, the master comment can state that it applies to other instances
below as well.
> > And normal code readability indicates putting the multi-line
> > comment above the macro call rather than embedding it in a macro argument.
>
> Concrete syntax is not an issue, just throw in more sed.
I think any check from the makefile is overcomplicating things (and the
question isn't whether there's a comment, it's whether there's a comment
explaning the warning suppression rather than some other aspect of the
code).
Again, the point of -Werror is primarily is to avoid changes to code
introducing new warnings by accident. Elaborate schemes around warning
control might improve quality in some circumstances but should come later,
once we have the basic infrastructure to avoid warning regressions, rather
than gating the use of -Werror.
--
Joseph S. Myers
joseph@codesourcery.com