This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: -Werror policy
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Roland McGrath <roland at hack dot frob dot com>
- Cc: <libc-alpha at sourceware dot org>
- Date: Mon, 24 Nov 2014 23:16:54 +0000
- Subject: Re: -Werror policy
- Authentication-results: sourceware.org; auth=none
- References: <alpine dot DEB dot 2 dot 10 dot 1411132331520 dot 5050 at digraph dot polyomino dot org dot uk> <20141114001831 dot 8C7CF2C3B16 at topped-with-meat dot com> <alpine dot DEB dot 2 dot 10 dot 1411140028450 dot 5050 at digraph dot polyomino dot org dot uk> <20141124221810 dot 391AC2C3B20 at topped-with-meat dot com>
On Mon, 24 Nov 2014, Roland McGrath wrote:
> > > However, I think we should probably write some internal macro using _Pragma
> > > that becomes the idiom rather than the whole push/pop boilerplate. We
> > > might even make the "mandatory comment" items be (ignored) string arguments
> > > to the macro, so it is quite hard to accidentally fail to supply the
> > > information.
> >
> > I think string arguments would likely be cumbersome when you have
> > explanations that may be more than one line long.
>
> Well, it was just the first thought. The point is to have something that
> serves as a reminder to write enough commentary. It doesn't really matter
> how much of the commentary is in an ignored string and how much is in
> nearby comments. The main thought I was having there is that something
> syntactically mandatory would be more helpful than a mere policy about
> having comments, in making sure we don't let something through review
> absentmindedly without requiring adequate comments to justify the warning
> suppression.
If we let things through without comments, I think they're just as likely
to go through with unhelpful or empty strings. Hence my proposed patch
having an unused argument only for a case where having some information
inside the macro call rather than elsewhere nearby seems useful (GCC
version with which the warning was observed, with a view to grepping for
cases needing review).
--
Joseph S. Myers
joseph@codesourcery.com