This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [Patch] Add .size directives to x86_64 start.S, and possibly more
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Sterling Augustine <saugustine at google dot com>
- Cc: Andreas Schwab <schwab at linux-m68k dot org>, GNU C Library <libc-alpha at sourceware dot org>, "Carlos O'Donell" <carlos at redhat dot com>
- Date: Mon, 24 Nov 2014 14:02:50 -0800
- Subject: Re: [Patch] Add .size directives to x86_64 start.S, and possibly more
- Authentication-results: sourceware.org; auth=none
- References: <CAEG7qUyQPNG1EtSwWSC77vUm+PZXUpDBtm5obab+Y5aa9Vv4-A at mail dot gmail dot com> <CAMe9rOq+bKtiJaAfa5sxx-PjiHLutdYBT1p=7K24KPcoB0pbug at mail dot gmail dot com> <CAEG7qUzM070Va4L1N=msw8t5uAFRp2WQmUryULen+99_zWpbKw at mail dot gmail dot com> <8761e8coo3 dot fsf at igel dot home> <CAEG7qUy-GJKtrdgz6ZYK5dx4P5E=yBWKrq-YGF3keS-zoMGiyg at mail dot gmail dot com> <CAMe9rOpcS0yied+Sr1+0zgDtGM=KTi_Qi3h+ujNdzZn9PZEdzQ at mail dot gmail dot com> <CAEG7qUzedb8HsZmiS=280yGq-_XOL1RzTLu-_R8LVDXEGiy0EA at mail dot gmail dot com>
On Mon, Nov 24, 2014 at 1:36 PM, Sterling Augustine
<saugustine@google.com> wrote:
> On Mon, Nov 24, 2014 at 10:50 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
>> Plain ENTRY is preferred if it works.
>
> I see no regressions on a "make check" using ENTRY and END. Assuming
> that is adequate testing, OK for trunk?
>
> 2014-11-24 Sterling Augustine <saugustine@google.com>
>
> * sysdeps/x86_64/start.S (_start): Use ENTRY and END macros.
>
>
>
> diff --git a/sysdeps/x86_64/start.S b/sysdeps/x86_64/start.S
> index e3d4ff8..97e972e 100644
> --- a/sysdeps/x86_64/start.S
> +++ b/sysdeps/x86_64/start.S
> @@ -55,11 +55,7 @@
>
> #include <sysdep.h>
>
> - .text
> - .globl _start
> - .type _start,@function
> -_start:
> - cfi_startproc
> +ENTRY (_start)
> /* Clearing frame pointer is insufficient, use CFI. */
> cfi_undefined (rip)
> /* Clear the frame pointer. The ABI suggests this be done, to mark
> @@ -123,7 +119,7 @@ _start:
> #endif
>
> hlt /* Crash if somehow `exit' does return. */
> - cfi_endproc
> +END (_start)
>
> /* Define a symbol for the first piece of initialized data. */
> .data
Looks good to me. Thanks.
--
H.J.