This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [Patch] Add .size directives to x86_64 start.S, and possibly more
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Sterling Augustine <saugustine at google dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>, carlos at redhat dot org
- Date: Fri, 21 Nov 2014 10:52:57 -0800
- Subject: Re: [Patch] Add .size directives to x86_64 start.S, and possibly more
- Authentication-results: sourceware.org; auth=none
- References: <CAEG7qUyQPNG1EtSwWSC77vUm+PZXUpDBtm5obab+Y5aa9Vv4-A at mail dot gmail dot com>
On Fri, Nov 21, 2014 at 10:44 AM, Sterling Augustine
<saugustine@google.com> wrote:
> Hello,
>
> sysdeps/x86_64/start.S doesn't have a .size elf directive for _start.
> This tripped up some analysis I was doing.
>
> This patch is the straightforward fix. Would you be interested in a
> similar fix for the ~150 assembly files inside x86_64 with similar
> issues?
>
> Sterling
>
> ChangeLog
>
> 2014-11-21 Sterling Augustine <saugustine@google.com>
>
> * sysdeps/x86_64/start.S: Add .size directive.
>
>
> diff --git a/sysdeps/x86_64/start.S b/sysdeps/x86_64/start.S
> index e3d4ff8..5106bd0 100644
> --- a/sysdeps/x86_64/start.S
> +++ b/sysdeps/x86_64/start.S
> @@ -124,6 +124,7 @@ _start:
>
> hlt /* Crash if somehow `exit' does return. */
> cfi_endproc
> + .size _start, .-_start
>
> /* Define a symbol for the first piece of initialized data. */
> .data
Why not use ENTRY/END macros?
--
H.J.