This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
[Patch] Add .size directives to x86_64 start.S, and possibly more
- From: Sterling Augustine <saugustine at google dot com>
- To: libc-alpha at sourceware dot org, carlos at redhat dot org
- Date: Fri, 21 Nov 2014 10:44:32 -0800
- Subject: [Patch] Add .size directives to x86_64 start.S, and possibly more
- Authentication-results: sourceware.org; auth=none
Hello,
sysdeps/x86_64/start.S doesn't have a .size elf directive for _start.
This tripped up some analysis I was doing.
This patch is the straightforward fix. Would you be interested in a
similar fix for the ~150 assembly files inside x86_64 with similar
issues?
Sterling
ChangeLog
2014-11-21 Sterling Augustine <saugustine@google.com>
* sysdeps/x86_64/start.S: Add .size directive.
diff --git a/sysdeps/x86_64/start.S b/sysdeps/x86_64/start.S
index e3d4ff8..5106bd0 100644
--- a/sysdeps/x86_64/start.S
+++ b/sysdeps/x86_64/start.S
@@ -124,6 +124,7 @@ _start:
hlt /* Crash if somehow `exit' does return. */
cfi_endproc
+ .size _start, .-_start
/* Define a symbol for the first piece of initialized data. */
.data