This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] [BZ 17542] sunrpc: conditional jump depends on uninitialised value in svc_getreq_common

From: Siddhesh Poyarekar <siddhesh at redhat dot com>
To: Andreas Schwab <schwab at suse dot de>
Cc: bhubbard at redhat dot com, libc-alpha at sourceware dot org
Date: Wed, 5 Nov 2014 15:07:51 +0530
Subject: Re: [PATCH] [BZ 17542] sunrpc: conditional jump depends on uninitialised value in svc_getreq_common
Authentication-results: sourceware.org; auth=none
References: <54597868 dot 3060408 at redhat dot com> <mvmr3xif28d dot fsf at hawking dot suse dot de> <20141105091434 dot GJ17703 at spoyarek dot pnq dot redhat dot com> <mvmioiuf0y4 dot fsf at hawking dot suse dot de>

On Wed, Nov 05, 2014 at 10:31:31AM +0100, Andreas Schwab wrote:
> > That is likely an application bug, but it might not be a bad idea to
> > include the patch anyway.  Failing the NULL check and returning seems
> > better than allowing to dereference arbitrary pointer values.
> 
> But what does this have to do with "sock > _rpc_dtablesize()"?

Nothing.  That analysis is incorrect AFAIK and it seems to be a
failure in calling xprt_register as you pointed out, which should be
an application bug.

Siddhesh

Attachment: pgpFZffjrtNxS.pgp
Description: PGP signature

References:
- [PATCH] [BZ 17542] sunrpc: conditional jump depends on uninitialised value in svc_getreq_common
  - From: Brad Hubbard
- Re: [PATCH] [BZ 17542] sunrpc: conditional jump depends on uninitialised value in svc_getreq_common
  - From: Andreas Schwab
- Re: [PATCH] [BZ 17542] sunrpc: conditional jump depends on uninitialised value in svc_getreq_common
  - From: Siddhesh Poyarekar
- Re: [PATCH] [BZ 17542] sunrpc: conditional jump depends on uninitialised value in svc_getreq_common
  - From: Andreas Schwab

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]