This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] [BZ 17542] sunrpc: conditional jump depends on uninitialised value in svc_getreq_common


On Wed, Nov 05, 2014 at 10:03:46AM +0100, Andreas Schwab wrote:
> Brad Hubbard <bhubbard@redhat.com> writes:
> 
> > Following is the valgrind warning.
> >
> > ==26802== Conditional jump or move depends on uninitialised value(s)
> > ==26802==    at 0x5343A25: svc_getreq_common (in /lib64/libc-2.5.so)
> 
> > ==26802==    by 0x534357B: svc_getreqset (in /lib64/libc-2.5.so)
> 
> Why was svc_getreqset called with file descriptors that were never seen
> by xprt_register?

That is likely an application bug, but it might not be a bad idea to
include the patch anyway.  Failing the NULL check and returning seems
better than allowing to dereference arbitrary pointer values.

Siddhesh

Attachment: pgpZAoRqztOPK.pgp
Description: PGP signature


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]