This is the mail archive of the
mailing list for the glibc project.
Re: [PATCH roland/nptl-sparc] Move remaining SPARC code out of nptl/.
- From: Roland McGrath <roland at hack dot frob dot com>
- To: David Miller <davem at davemloft dot net>
- Cc: libc-alpha at sourceware dot org
- Date: Mon, 23 Jun 2014 10:08:40 -0700 (PDT)
- Subject: Re: [PATCH roland/nptl-sparc] Move remaining SPARC code out of nptl/.
- Authentication-results: sourceware.org; auth=none
- References: <20140619 dot 212959 dot 236229985863526469 dot davem at davemloft dot net> <20140621001628 dot 4B55B2C39BF at topped-with-meat dot com> <20140620 dot 201345 dot 1674593995772757397 dot davem at davemloft dot net> <20140622 dot 170145 dot 629623305418182283 dot davem at davemloft dot net>
> There appears to be a problem with putting this stuff under
> sysdeps/sparc/nptl, in that header files under
> nptl/sysdeps/unix/sysv/linux/ will be choosen first.
> As a result, sysdeps/sparc/nptl/internaltypes.h won't be used, instead we
> end up using nptl/sysdeps/unix/sysv/linux/internaltypes.h.
OK, I have three answers:
1. The quickest fix is just to move it back to sysdeps/.../linux/sparc/.
2. The sparc internaltypes.h doesn't actually define anything differently
from the common one. It just adds extra types that are used only by a
few sparc implementation .c files. So it could just be a separate
sparc-specific header by a different name. This might be what's really
the best idea, on the general principle that if you can do your
machine-specific work just as cleanly with new machine-specific files
that do not interact with shared sysdeps files, then that choice
simplifies things by reducing such interactions that you or other
maintainers have to worry about in the future.
3. The "linux" internaltypes.h in fact does not contain any deep Linuxisms.
So as part of my ongoing cleanup I was about to move this to someplace
else more common, such as nptl/ or sysdeps/nptl/. That will fix your
problem for you incidentally, and I was probably going to do that today