This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH roland/nptl-sparc] Move remaining SPARC code out of nptl/.
- From: David Miller <davem at davemloft dot net>
- To: roland at hack dot frob dot com
- Cc: libc-alpha at sourceware dot org
- Date: Sun, 22 Jun 2014 17:01:45 -0700 (PDT)
- Subject: Re: [PATCH roland/nptl-sparc] Move remaining SPARC code out of nptl/.
- Authentication-results: sourceware.org; auth=none
- References: <20140619 dot 212959 dot 236229985863526469 dot davem at davemloft dot net> <20140621001628 dot 4B55B2C39BF at topped-with-meat dot com> <20140620 dot 201345 dot 1674593995772757397 dot davem at davemloft dot net>
From: David Miller <davem@davemloft.net>
Date: Fri, 20 Jun 2014 20:13:45 -0700 (PDT)
> From: Roland McGrath <roland@hack.frob.com>
> Date: Fri, 20 Jun 2014 17:16:28 -0700 (PDT)
>
>> I've committed it. Please draw my attention to any follow-on fixes you
>> find necessary (or even just desirable), so I can be on the lookout not to
>> repeat mistakes with other machines.
>
> Will do.
There appears to be a problem with putting this stuff under sysdeps/sparc/nptl,
in that header files under nptl/sysdeps/unix/sysv/linux/ will be choosen first.
As a result, sysdeps/sparc/nptl/internaltypes.h won't be used, instead we end up
using nptl/sysdeps/unix/sysv/linux/internaltypes.h.
This leads to the build failing:
../sysdeps/sparc/nptl/pthread_barrier_destroy.c: In function ʽpthread_barrier_destroyʼ:
../sysdeps/sparc/nptl/pthread_barrier_destroy.c:32:25: error: dereferencing pointer to incomplete type
...
etc.
I can't think of an easy way to fix this.