This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Do not terminate default test runs on test failure
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Andreas Schwab <schwab at suse dot de>
- Cc: Carlos O'Donell <carlos at redhat dot com>, <libc-alpha at sourceware dot org>
- Date: Tue, 1 Apr 2014 14:12:42 +0000
- Subject: Re: Do not terminate default test runs on test failure
- Authentication-results: sourceware.org; auth=none
- References: <Pine dot LNX dot 4 dot 64 dot 1403071741020 dot 6302 at digraph dot polyomino dot org dot uk> <mvm38hyfl2x dot fsf at hawking dot suse dot de> <Pine dot LNX dot 4 dot 64 dot 1403311712520 dot 15146 at digraph dot polyomino dot org dot uk> <87ha6e3yx3 dot fsf at igel dot home> <Pine dot LNX dot 4 dot 64 dot 1403312023250 dot 10829 at digraph dot polyomino dot org dot uk> <mvmppl1ebt8 dot fsf at hawking dot suse dot de> <Pine dot LNX dot 4 dot 64 dot 1404011146310 dot 24927 at digraph dot polyomino dot org dot uk> <mvmppl19ox7 dot fsf at hawking dot suse dot de>
On Tue, 1 Apr 2014, Andreas Schwab wrote:
> "Joseph S. Myers" <joseph@codesourcery.com> writes:
>
> > On Tue, 1 Apr 2014, Andreas Schwab wrote:
> >
> >> "Joseph S. Myers" <joseph@codesourcery.com> writes:
> >>
> >> > That means that some dependency of the toplevel tests target failed
> >> > (possibly because a test failed to compile), in which case the commands
> >> > for that target don't get run. Generation of summaries relies on
> >> > dependencies not failing
> >>
> >> This is a serious regression, please fix ASAP.
> >
> > I see no regression from my patch.
>
> The regression is the ability to see all testsuite failures in the build
> log.
Use cases that involve identifying a list of failures from a build log are
expected to involve changes to the system you use to list failures - that
is, this is working as designed. Either set stop-on-test-failure or
combine build failures from the build log with test failures from
.test-result files, if there is some good reason the build failures can't
be fixed first before looking at other issues.
You still haven't said what the build failures are or what platform you
see them on. I don't see build failures in a testsuite run on x86_64.
(I do see elf/tst-dlopen-aout failing - contrary to the comment saying it
only fails if --enable-hardcoded-path-in-tests - and consider it rather
dubious to have a test like that that fails in a default testsuite
configuration; a test depending on --enable-hardcoded-path-in-tests should
be disabled completely when the testsuite is run differently.)
--
Joseph S. Myers
joseph@codesourcery.com