This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Do not terminate default test runs on test failure
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Andreas Schwab <schwab at suse dot de>
- Cc: Carlos O'Donell <carlos at redhat dot com>, <libc-alpha at sourceware dot org>
- Date: Tue, 1 Apr 2014 11:50:03 +0000
- Subject: Re: Do not terminate default test runs on test failure
- Authentication-results: sourceware.org; auth=none
- References: <Pine dot LNX dot 4 dot 64 dot 1403071741020 dot 6302 at digraph dot polyomino dot org dot uk> <mvm38hyfl2x dot fsf at hawking dot suse dot de> <Pine dot LNX dot 4 dot 64 dot 1403311712520 dot 15146 at digraph dot polyomino dot org dot uk> <87ha6e3yx3 dot fsf at igel dot home> <Pine dot LNX dot 4 dot 64 dot 1403312023250 dot 10829 at digraph dot polyomino dot org dot uk> <mvmppl1ebt8 dot fsf at hawking dot suse dot de>
On Tue, 1 Apr 2014, Andreas Schwab wrote:
> "Joseph S. Myers" <joseph@codesourcery.com> writes:
>
> > That means that some dependency of the toplevel tests target failed
> > (possibly because a test failed to compile), in which case the commands
> > for that target don't get run. Generation of summaries relies on
> > dependencies not failing
>
> This is a serious regression, please fix ASAP.
I see no regression from my patch.
Suppose there is a build failure for some test (and you need to make clear
exactly what errors you see, on what architecture, before we can start to
work out the correct way to address them).
If you don't use -k, then, both before and after my patch, the test run
stops with error status when that build failure occurs, without printing a
summary of results. No regression.
If you do use -k, then, both before and after my patch, the test run
continues past the failure to run as many tests as possible, and once the
possible tests have run it finishes with error status, without printing a
summary of results. No regression.
Maybe some other patch - say, the -Wundef patch - caused a regression, but
you haven't given sufficient information about the actual failures you see
and the configuration in which you see them to determine the right fix.
--
Joseph S. Myers
joseph@codesourcery.com