This is the mail archive of the
mailing list for the glibc project.
Re: build for sh fails with "fanotify_mark@@VERSION_libc_er"
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: Kaz Kojima <kkojima at rr dot iij4u dot or dot jp>, roland at hack dot frob dot com
- Cc: libc-alpha at sourceware dot org
- Date: Thu, 12 Dec 2013 12:49:56 -0500
- Subject: Re: build for sh fails with "fanotify_mark@@VERSION_libc_er"
- Authentication-results: sourceware.org; auth=none
- References: <20131212 dot 075140 dot 511260784 dot kkojima at rr dot iij4u dot or dot jp> <20131212030653 dot 0D02C74428 at topped-with-meat dot com> <20131212 dot 135038 dot 371146801 dot kkojima at rr dot iij4u dot or dot jp>
On 12/11/2013 11:50 PM, Kaz Kojima wrote:
> Roland McGrath <firstname.lastname@example.org> wrote:
>> Your fix is correct (and obvious enough).
>> What's surprising is that this wasn't breaking any other case.
> Is it OK as an obvious fix with the ChangeLog entry below?
> 2013-12-12 Kaz Kojima <email@example.com>
> * sysdeps/unix/Makefile ($(objpfx)stub-syscalls.c): Double $ in
* sysdeps/unix/Makefile ($(objpfx)stub-syscalls.c): Use $$ver.
OK with that.
Thankfully this broke only just recently at 2013-09-11 by
0a834ddecbb08b79cbcf7d9460ab3d3d539c9962. So there has been no
release with this fix for removing bash-isms.
My gut says that on all other targets we probably don't have
any stubs so this never showed up because this code was never
called. Every other architecture probably has fanotify_mark
generated by a syscall wrapper, not a syscall stub.
So the followup question is why does sh use a do-nothing
stub for this?