This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH][benchtests] Use benchmark framework for strtod
- From: Siddhesh Poyarekar <siddhesh at redhat dot com>
- To: Adhemerval Zanella <azanella at linux dot vnet dot ibm dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Wed, 4 Dec 2013 18:18:55 +0530
- Subject: Re: [PATCH][benchtests] Use benchmark framework for strtod
- Authentication-results: sourceware.org; auth=none
- References: <20131204074418 dot GP14845 at spoyarek dot pnq dot redhat dot com> <529F1811 dot 5090604 at linux dot vnet dot ibm dot com>
On Wed, Dec 04, 2013 at 09:54:57AM -0200, Adhemerval Zanella wrote:
> Hi Siddhesh,
>
> With this patch, I'm seeing some compilations errors when issuing 'make bench':
>
Sorry, I think I forgot to explicitly mention that this patch needs
the following patch too:
https://sourceware.org/ml/libc-alpha/2013-12/msg00122.html
The compilation error looks like something I'd see if this patch
wasn't included. Could you please confirm?
Thanks,
Siddhesh
> error: expected identifier or â(â before â<â token
> struct args { volatile const char * arg0; volatile <char **> arg1;};
> ^
> /home/azanella/glibc/build/glibc64_power7/benchtests/bench-strtod.c:3:67: warning: no semicolon at end of struct or union [enabled by default]
> struct args { volatile const char * arg0; volatile <char **> arg1;};
> ^
> ./bench-skeleton.c: In function âmainâ:
> /home/azanella/glibc/build/glibc64_power7/benchtests/bench-strtod.c:2:81: error: âstruct argsâ has no member named âarg1â
> #define CALL_BENCH_FUNC(v, i) strtod ( variants[v].in[i].arg0, variants[v].in[i].arg1);
> ^
> /home/azanella/glibc/build/glibc64_power7/benchtests/bench-strtod.c:75:35: note: in expansion of macro âCALL_BENCH_FUNCâ
> #define BENCH_FUNC(i, j) ({ret = CALL_BENCH_FUNC (i, j);})
> ^
> ./bench-skeleton.c:77:3: note: in expansion of macro âBENCH_FUNCâ
> BENCH_FUNC (v, i);
> ^
> In file included from /home/azanella/glibc/build/glibc64_power7/benchtests/bench-strtod.c:77:0:
> ./bench-skeleton.c:77:3: warning: passing argument 1 of âstrtodâ discards âvolatileâ qualifier from pointer target type [enabled by default]
> In file included from ../include/stdlib.h:10:0,
> from /home/azanella/glibc/build/glibc64_power7/benchtests/bench-strtod.c:1:
> ../stdlib/stdlib.h:164:15: note: expected âconst char * restrictâ but argument is of type âconst volatile char *â
> extern double strtod (const char *__restrict __nptr,
> ^
> make[1]: *** [/home/azanella/glibc/build/glibc64_power7/benchtests/bench-strtod.o] Error 1
>