This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PING][PATCH][BZ #926] Mention timezone for strftime %s

On Tuesday 05 November 2013 09:30:05 OndÅej BÃlka wrote:
> On Wed, Oct 30, 2013 at 11:22:20AM -0700, Paul Eggert wrote:
> > On 10/30/2013 08:38 AM, OndÅej BÃlka wrote:
> > > +Note that like mktime, this uses the current time zone instead of
> > > tm_gmtoff.
> > 
> > I like the idea of documenting this part of strftime, but the proposed
> > documentation could be improved.  First, it's not just tm_gmtoff; it's
> > also tm_zone.  Second, the documentation for mktime doesn't mention
> > the fact that mktime uses the current time zone rather than tm_gmtoff,
> > and it's odd that one must look to strftime to find this fact
> > documented.  Third, words like mktime and tm_gmtoff should be marked
> > with @code.  Fourth, let's omit the "Note that."  And finally, there
> > are similar problems elsewhere in that chapter.
> > 
> > How about the following patch instead?
> Yes, this one is better.

one of you want to merge it then ? :)

Attachment: signature.asc
Description: This is a digitally signed message part.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]