This is the mail archive of the
mailing list for the glibc project.
Re: [PING][PATCH][BZ #926] Mention timezone for strftime %s
- From: OndÅej BÃlka <neleai at seznam dot cz>
- To: Paul Eggert <eggert at cs dot ucla dot edu>
- Cc: libc-alpha at sourceware dot org
- Date: Tue, 5 Nov 2013 15:30:05 +0100
- Subject: Re: [PING][PATCH][BZ #926] Mention timezone for strftime %s
- Authentication-results: sourceware.org; auth=none
- References: <20131012165835 dot GA26247 at domone dot podge> <20131017154245 dot GG31767 at domone dot podge> <20131023124339 dot GC5434 at domone dot podge> <20131030153842 dot GD16867 at domone dot podge> <52714E5C dot 5000006 at cs dot ucla dot edu>
On Wed, Oct 30, 2013 at 11:22:20AM -0700, Paul Eggert wrote:
> On 10/30/2013 08:38 AM, OndÅej BÃlka wrote:
> > +Note that like mktime, this uses the current time zone instead of tm_gmtoff.
> I like the idea of documenting this part of strftime, but the proposed
> documentation could be improved. First, it's not just tm_gmtoff; it's
> also tm_zone. Second, the documentation for mktime doesn't mention
> the fact that mktime uses the current time zone rather than tm_gmtoff,
> and it's odd that one must look to strftime to find this fact
> documented. Third, words like mktime and tm_gmtoff should be marked
> with @code. Fourth, let's omit the "Note that." And finally, there
> are similar problems elsewhere in that chapter.
> How about the following patch instead?
Yes, this one is better.