This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Add sysdeps/x86/i686

From: Roland McGrath <roland at hack dot frob dot com>
To: "H.J. Lu" <hjl dot tools at gmail dot com>
Cc: GNU C Library <libc-alpha at sourceware dot org>
Date: Fri, 11 Jan 2013 14:05:05 -0800 (PST)
Subject: Re: [PATCH] Add sysdeps/x86/i686
References: <20130106004333.GA28831@intel.com><20130110214311.46C242C0AD@topped-with-meat.com><CAMe9rOrpi12j3kgm9smugBPpVSNQvZgXG_pFynuEyqSVidj_2Q@mail.gmail.com>

> I'd like to put common sources between i686 and x86-64 under
> sysdeps/x86/i686 instead of duplicating them.  I have a patch
> to move common x86 multiarch sources to sysdeps/x86/i686/multiarch.

If you are adding #ifdef's then they are not really common.  If there
are things where the exact same source is used, and more than just a
few of them, then that is a compelling reason to add a new shared
sysdeps directory.  Let's start with just those pure cases.

Follow-Ups:
- Re: [PATCH] Add sysdeps/x86/i686
  - From: H.J. Lu

References:
- [PATCH] Add sysdeps/x86/i686
  - From: H.J. Lu
- Re: [PATCH] Add sysdeps/x86/i686
  - From: Roland McGrath
- Re: [PATCH] Add sysdeps/x86/i686
  - From: H.J. Lu

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]