This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Add sysdeps/x86/i686

On Fri, Jan 11, 2013 at 2:05 PM, Roland McGrath <> wrote:
>> I'd like to put common sources between i686 and x86-64 under
>> sysdeps/x86/i686 instead of duplicating them.  I have a patch
>> to move common x86 multiarch sources to sysdeps/x86/i686/multiarch.
> If you are adding #ifdef's then they are not really common.  If there
> are things where the exact same source is used, and more than just a
> few of them, then that is a compelling reason to add a new shared
> sysdeps directory.  Let's start with just those pure cases.

I checked my changes into hjl/x86 branch:

[hjl@gnu-6 glibc]$ ls sysdeps/x86/i686/multiarch
ifunc-defines.sym  strcasestr-c.c         strspn-c.c        Versions
init-arch.c        strcasestr-nonascii.c  strstr.c          wcscpy-c.c
init-arch.h        strcspn-c.c            strstr-c.c        wmemcmp-c.c
Makefile           strncat-c.c            test-multiarch.c
sched_cpucount.c   strncpy-c.c            varshift.c
strcasestr.c       strpbrk-c.c            varshift.h
[hjl@gnu-6 glibc]$

There are no checking for __x86_64__.  The same sources are
used for both i686 and x86-64.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]