This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: vfprintf typing problem


On 03/30/2012 01:18 AM, David Miller wrote:
> +    if (__builtin_expect ((unsigned int) INT_MAX - (unsigned int) done	      \
> +			  < (Len), 0))					      \

Since the values are all nonnegative there should be no need
to cast to unsigned int.  Could you please remove the casts?
They add confusion, since the reader is left wondering
why they're there at all.

> +	if (__builtin_expect ((unsigned int) width >= INT_MAX
> +			      / sizeof (CHAR_T) - 32, 0))

Likewise.

> -      if (__builtin_expect (width >= (size_t) -1 / sizeof (CHAR_T) - 32, 0))
> +      if (__builtin_expect ((unsigned int) width >= INT_MAX / sizeof (CHAR_T) - 32, 0))

Likewise.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]