This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Unbound alloca in crypt routines - V2


On 03/29/2012 04:36 PM, Carlos O'Donell wrote:

OK to checkin if you...


(1) Adjust the copyright year on each file.
Done. I just realized I didn't bump the copyright on Siddhesh's patches from the last couple days. I'll make sure to bump those as well as an independent checkin.



and...


(2) Always add alloca_used to the size passed to __libc_use_alloca
even if alloca_used would equal 0, that way someone in the future
won't accidentally make the mistake if putting an alloca *before* your
first call to __libc_use_alloca and forget to fixup the other caller
to include "alloca_used +".
Good point. Done.

Committed.

Thanks,

Jeff


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]