This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: vfprintf typing problem

From: David Miller <davem at davemloft dot net>
To: eggert at cs dot ucla dot edu
Cc: libc-alpha at sourceware dot org
Date: Fri, 30 Mar 2012 21:24:12 -0400 (EDT)
Subject: Re: vfprintf typing problem
References: <20120328.192604.144405909745491673.davem@davemloft.net><20120330.041829.1931398921837251265.davem@davemloft.net><4F75C963.9070600@cs.ucla.edu>

From: Paul Eggert <eggert@cs.ucla.edu>
Date: Fri, 30 Mar 2012 07:55:31 -0700

> On 03/30/2012 01:18 AM, David Miller wrote:
>> +    if (__builtin_expect ((unsigned int) INT_MAX - (unsigned int) done	      \
>> +			  < (Len), 0))					      \
> 
> Since the values are all nonnegative there should be no need
> to cast to unsigned int.  Could you please remove the casts?
> They add confusion, since the reader is left wondering
> why they're there at all.

Will do, thanks.

References:
- Re: vfprintf typing problem
  - From: David Miller
- Re: vfprintf typing problem
  - From: David Miller
- Re: vfprintf typing problem
  - From: Paul Eggert

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]