This is the mail archive of the insight@sourceware.org mailing list for the Insight project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

[PATCH/gdbtk] Fix crash when running insight with pending breakpoints

From: Roland Schwingel <roland at onevision dot com>
To: insight at sourceware dot org
Date: Wed, 11 Apr 2012 14:28:21 +0200
Subject: [PATCH/gdbtk] Fix crash when running insight with pending breakpoints

Hi...

When I set breakpoints in insight it remembers it after restart. If the breakpoint is in a shared library (dll) it is created as pending breakpoint after restart. But when I restart insight it is crashing as soon as I click the "Run" button top left in the source window.

This is reasoned by the fact that pending breakpoint has a NULL location pointer, but the location is dereferenced by.

The attached simple patch fixes this.

Changelog:

2012-04-11 Roland Schwingel <roland.schwingel@onevision.com>

	* generic/gdbtk-bp.c: Updated copyright.
	(gdb_find_bp_at_line): Don't access location struct
	of breakpoint if it is NULL.

Any comments? Is this ok?

Roland

Attachment: pending_bp_crash.patch
Description: Text document

Follow-Ups:
- Re: [PATCH/gdbtk] Fix crash when running insight with pending breakpoints
  - From: Keith Seitz

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]