This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2 0/7] Enable -Wmissing-declarations diagnostic
- From: Simon Marchi <simark at simark dot ca>
- To: Tom Tromey <tom at tromey dot com>, Simon Marchi <simon dot marchi at efficios dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Sat, 11 Jan 2020 21:48:10 -0500
- Subject: Re: [PATCH v2 0/7] Enable -Wmissing-declarations diagnostic
- References: <20200110220027.26450-1-simon.marchi@efficios.com> <87d0bqexxj.fsf@tromey.com>
On 2020-01-11 11:54 a.m., Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simon.marchi@efficios.com> writes:
>
> Simon> This is v2 of:
> Simon> https://sourceware.org/ml/gdb-patches/2019-11/msg00805.html
>
> Simon> Although a few patches of the original series were merged, since they
> Simon> were valid fixes in any case.
>
> I read through the series.
>
> I think this warning would be good to have, because it can help detect
> bugs. It's maybe mildly unfortunate that we have to have the first
> patch, but at the same time it's not that much noise in the end -- just
> an extra line (typically) near the end of a file. The other patches all
> seem desirable on their own terms.
>
> So, I think you should check it in.
Thanks again for the tip to finish the last patch. This is v2, and v1 was
sent a while ago, so I figure that if somebody was against it, they would
have spoken up by now. So I'll rebase and push it. Sorry in advance for
the breakages on the configs I am not able to build easily.
Simon